diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 53cac00a..a9eedc8a 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -9,7 +9,7 @@ jobs: - uses: actions/checkout@master - name: TFLint uses: docker://wata727/tflint - + fmt: name: Code Format runs-on: ubuntu-latest @@ -18,7 +18,7 @@ jobs: steps: - uses: actions/checkout@master - run: terraform fmt --recursive -check=true - + docs: name: Docs runs-on: macOS-latest @@ -51,3 +51,19 @@ jobs: terraform validate cd - done + + minimum: + name: Minimum version check + runs-on: ubuntu-latest + container: + image: hashicorp/terraform:0.12.2 + steps: + - uses: actions/checkout@master + - name: Validate Code + env: + AWS_REGION: 'us-east-1' + TF_WARN_OUTPUT_ERRORS: 1 + run: | + sed -i -e 's/>=/=/' -e 's/ \(\d\+\.\d\+\)"/ \1.0"/' versions.tf + terraform init + terraform validate -var "region=${AWS_REGION}" -var "vpc_id=vpc-123456" -var "subnets=[\"subnet-12345a\"]" -var "workers_ami_id=ami-123456" -var "cluster_ingress_cidrs=[]" -var "cluster_name=test_cluster" diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e55d287..a02b2225 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ project adheres to [Semantic Versioning](http://semver.org/). ### Changed -- Write your awesome change here (by @you) +- Updated instance_profile_names and instance_profile_arns outputs to also consider launch template as well as asg (by @ankitwal) # History diff --git a/outputs.tf b/outputs.tf index 9f6efa11..7c7de9d6 100644 --- a/outputs.tf +++ b/outputs.tf @@ -114,12 +114,18 @@ output "worker_security_group_id" { output "worker_iam_instance_profile_arns" { description = "default IAM instance profile ARN for EKS worker groups" - value = aws_iam_instance_profile.workers.*.arn + value = concat( + aws_iam_instance_profile.workers.*.arn, + aws_iam_instance_profile.workers_launch_template.*.arn + ) } output "worker_iam_instance_profile_names" { description = "default IAM instance profile name for EKS worker groups" - value = aws_iam_instance_profile.workers.*.name + value = concat( + aws_iam_instance_profile.workers.*.name, + aws_iam_instance_profile.workers_launch_template.*.name + ) } output "worker_iam_role_name" {