xpk/terraform-aws-eks
1
0
Fork 0
mirror of https://github.com/terraform-aws-modules/terraform-aws-eks.git synced 2025-09-09 19:32:58 +08:00
Code Activity

fix: Remediate type mismatch for EFA interfaces and ensure correct (local) definition is used (#3491)

Browse Source
This commit is contained in:
Bryant Biggs
2025-08-24 12:59:13 -05:00
committed by GitHub
parent f56e87eecd
commit 3959b65672
8 changed files with 92 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/eks-managed-node-group/main.tf
+7 -10
View File
@@ -318,14 +318,15 @@ module "eks" {
}
efa = {
# Disabling automatic creation due to instance type/quota availability
# Can be enabled when appropriate for testing/validation
create = false
# The EKS AL2023 NVIDIA AMI provides all of the necessary components
# for accelerated workloads w/ EFA
ami_type = "AL2023_x86_64_NVIDIA"
instance_types = ["p5e.48xlarge"]
instance_types = ["p4d.24xlarge"]
# Setting to zero so all resources are created *EXCEPT the EC2 instances
min_size = 0
max_size = 1
desired_size = 0
# Mount instance store volumes in RAID-0 for kubelet and containerd
# https://github.com/awslabs/amazon-eks-ami/blob/master/doc/USER_GUIDE.md#raid-0-for-kubelet-and-containerd-raid0
@@ -350,11 +351,7 @@ module "eks" {
# 3. Expose all of the available EFA interfaces on the launch template
enable_efa_support = true
enable_efa_only = true
efa_indices = [0, 4, 8, 12]
min_size = 1
max_size = 1
desired_size = 1
efa_indices = [0]
labels = {
"vpc.amazonaws.com/efa.present" = "true"
tests/self-managed-node-group/main.tf
+7 -10
View File
@@ -309,14 +309,15 @@ module "eks" {
}
efa = {
# Disabling automatic creation due to instance type/quota availability
# Can be enabled when appropriate for testing/validation
create = false
# The EKS AL2023 NVIDIA AMI provides all of the necessary components
# for accelerated workloads w/ EFA
ami_type = "AL2023_x86_64_NVIDIA"
instance_types = ["p5e.48xlarge"]
instance_types = ["p4d.24xlarge"]
# Setting to zero so all resources are created *EXCEPT the EC2 instances
min_size = 0
max_size = 1
desired_size = 0
# Mount instance store volumes in RAID-0 for kubelet and containerd
# https://github.com/awslabs/amazon-eks-ami/blob/master/doc/USER_GUIDE.md#raid-0-for-kubelet-and-containerd-raid0
@@ -341,11 +342,7 @@ module "eks" {
# 3. Expose all of the available EFA interfaces on the launch template
enable_efa_support = true
enable_efa_only = true
efa_indices = [0, 4, 8, 12]
min_size = 2
max_size = 2
desired_size = 2
efa_indices = [0]
labels = {
"vpc.amazonaws.com/efa.present" = "true"