feat: revamped aws-backup module

modules/storage/aws-backup/main.tf

@@ -1,63 +1,66 @@
-# build local data structure
+/**
+* # aws-backup
+*
+* Module to configure AWSBackup service opt in and manage backup settings for typical workloads
+ */
 
 data "aws_caller_identity" "this" {}
 
 locals {
   backup-config = {
     "Aurora" : {
-      enabled    = var.service-opt-in.Aurora.enabled
+      enabled    = var.service-opt-in["Aurora"].enabled
       arn-prefix = "arn:aws:rds:*:*:cluster:*"
     }
     "DynamoDB" : {
-      enabled    = var.service-opt-in.DynamoDB.enabled
+      enabled    = var.service-opt-in["DynamoDB"].enabled
       arn-prefix = "arn:aws:dynamodb:*:*:table/*"
     }
     "EBS" : {
-      enabled    = var.service-opt-in.EBS.enabled
+      enabled    = var.service-opt-in["EBS"].enabled
       arn-prefix = "arn:aws:ec2:*:*:volume/*"
     }
     "EC2" : {
-      enabled    = var.service-opt-in.EC2.enabled
+      enabled    = var.service-opt-in["EC2"].enabled
       arn-prefix = "arn:aws:ec2:*:*:instance/*"
     }
     "EFS" : {
-      enabled    = var.service-opt-in.EFS.enabled
+      enabled    = var.service-opt-in["EFS"].enabled
       arn-prefix = "arn:aws:elasticfilesystem:*:*:file-system/*"
     }
     "FSx" : {
-      enabled    = var.service-opt-in.FSx.enabled
+      enabled    = var.service-opt-in["FSx"].enabled
       arn-prefix = "arn:*:fsx:*"
     }
     "Redshift" : {
-      enabled    = var.service-opt-in.Redshift.enabled
+      enabled    = var.service-opt-in["Redshift"].enabled
       arn-prefix = "arn:aws:redshift:*:*:cluster:*"
     }
     "RDS" : {
-      enabled    = var.service-opt-in.RDS.enabled
+      enabled    = var.service-opt-in["RDS"].enabled
       arn-prefix = "arn:aws:rds:*:*:db:*"
     }
-    # this version can't handle space
-    #     "Storage Gateway" : {
-    #       enabled    = var.opt-in-storagegateway
-    #       arn-prefix = "arn:aws:storagegateway:*:*:gateway/*"
-    #     }
+    "Storage Gateway" : {
+      enabled    = var.service-opt-in["Storage Gateway"].enabled
+      arn-prefix = "arn:aws:storagegateway:*:*:gateway/*"
+    }
     "VirtualMachine" : {
-      enabled    = var.service-opt-in.VirtualMachine.enabled
+      enabled    = var.service-opt-in["VirtualMachine"].enabled
       arn-prefix = "arn:aws:backup-gateway:*:*:vm/*"
     }
     "S3" : {
-      enabled    = var.service-opt-in.S3.enabled
+      enabled    = var.service-opt-in["S3"].enabled
       arn-prefix = "arn:aws:s3:::*"
     }
     "EKS" : {
-      enabled    = var.service-opt-in.EKS.enabled
+      enabled    = var.service-opt-in["EKS"].enabled
       arn-prefix = "arn:aws:eks:*:*:cluster/*"
     }
     "CloudFormation" : {
-      enabled = var.service-opt-in.CloudFormation.enabled
+      enabled = var.service-opt-in["CloudFormation"].enabled
     }
     "Neptune" : {
-      enabled = var.service-opt-in.Neptune.enabled
+      enabled = var.service-opt-in["Neptune"].enabled
     }
     "Redshift Serverless" : {
       enabled = var.service-opt-in["Redshift Serverless"].enabled
@@ -82,7 +85,7 @@ resource "aws_backup_vault" "ab-vault" {
     for k, v in local.backup-config : k
     if v.enabled
   ])
-  name        = "BackupVault-${each.value}"
+  name        = "BackupVault-${trimspace(each.value)}"
   kms_key_arn = var.backup_kms_key
 }
 
@@ -161,12 +164,15 @@ resource "aws_backup_plan" "ab-plan" {
     }
   }
 
-  #   advanced_backup_setting {
-  #     backup_options = {
-  #       WindowsVSS = "enabled"
-  #     }
-  #     resource_type = "EC2"
-  #   }
+  dynamic "advanced_backup_setting" {
+    for_each = var.enable-vss ? [1] : []
+    content {
+      backup_options = {
+        WindowsVSS = "enabled"
+      }
+      resource_type = "EC2"
+    }
+  }
 }
 #
 resource "aws_iam_role" "ab-iam-role" {