From fd8d1416620cf3b1cf15affe2f34b7070a314eafe6e9348a0117382d21453e1a Mon Sep 17 00:00:00 2001
From: xpk <xpk@headdesk.me>
Date: Thu, 19 Feb 2026 14:18:01 +0800
Subject: [PATCH] feat: changed ec2 module and updated readme

---
 LocalStack/Compute/LabEc2/main.tf    | 36 +++++++++++++++-------------
 LocalStack/Compute/LabEc2/outputs.tf |  5 +++-
 LocalStack/README.md                 |  6 ++++-
 3 files changed, 29 insertions(+), 18 deletions(-)

diff --git a/LocalStack/Compute/LabEc2/main.tf b/LocalStack/Compute/LabEc2/main.tf
index 55183bb..0b6e4b9 100644
--- a/LocalStack/Compute/LabEc2/main.tf
+++ b/LocalStack/Compute/LabEc2/main.tf
@@ -8,23 +8,27 @@
 # }
 
 module "TestInstance" {
-  source = "../../../modules/compute/ec2"
+  source  = "terraform-aws-modules/ec2-instance/aws"
+  version = "6.2.0"
 
-  additional-tags  = {}
-  ami-id           = data.aws_ami.this.id
-  asso-eip         = false
-  asso-public-ip   = false
-  data-volumes     = {}
-  instance-name    = "TestInstance001"
-  instance-type    = "t4g.large"
-  kms-key-id       =  module.KmsKeys.cmks["allpurpose"].arn
-  root-volume-size = 20
-  security-groups  = []
-  subnet-id        = data.terraform_remote_state.vpc.outputs.private_subnets[0]
-  user-data        = <<EOF
-#!/bin/bash
-dnf -y install git
-EOF
+  ami                         = data.aws_ami.this.id
+  associate_public_ip_address = false
+  create_eip                  = false
+  name                        = "TestInstance001"
+  instance_type               = "t4g.large"
+  subnet_id                   = data.terraform_remote_state.vpc.outputs.private_subnets[0]
+  create_security_group       = false
+  root_block_device = {
+    device_name           = "/dev/xvda"
+    type                  = "gp3"
+    size                  = 20
+    delete_on_termination = true
+    kms_key_id            = module.KmsKeys.cmks["allpurpose"].arn
+  }
+  metadata_options = {
+    http_put_response_hop_limit = 2
+    http_tokens                 = "required"
+  }
 }
 
 data "aws_ami" "this" {
diff --git a/LocalStack/Compute/LabEc2/outputs.tf b/LocalStack/Compute/LabEc2/outputs.tf
index df4de36..370beac 100644
--- a/LocalStack/Compute/LabEc2/outputs.tf
+++ b/LocalStack/Compute/LabEc2/outputs.tf
@@ -1,3 +1,6 @@
 output "instance_info" {
-  value = module.TestInstance.ec2-id-ip
+  value = {
+    id         = module.TestInstance.id,
+    private_ip = module.TestInstance.private_ip
+  }
 }
\ No newline at end of file
diff --git a/LocalStack/README.md b/LocalStack/README.md
index beb73af..c416f30 100644
--- a/LocalStack/README.md
+++ b/LocalStack/README.md
@@ -60,4 +60,8 @@ For example, vpc with ipv6 could not be created. It failed with the following er
 │   on .terraform/modules/vpc/main.tf line 293, in resource "aws_subnet" "private":
 │  293: resource "aws_subnet" "private" {
 
-```
\ No newline at end of file
+```
+
+Also, ec2 instance's associate_public_ip_address attribute is always set to true, despite
+it is set to false in my code. This caused the instance to be redeployed everytime terraform
+apply is ran.
\ No newline at end of file